Skip to content

fix: navigation is blocked after clicking View Source#1496

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
rzzf:fix/1483
Feb 14, 2026
Merged

fix: navigation is blocked after clicking View Source#1496
ghostdevv merged 1 commit intonpmx-dev:mainfrom
rzzf:fix/1483

Conversation

@rzzf
Copy link
Contributor

@rzzf rzzf commented Feb 14, 2026

fix #1483

@vercel
Copy link

vercel bot commented Feb 14, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 14, 2026 8:09am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 14, 2026 8:09am
npmx-lunaria Ignored Ignored Feb 14, 2026 8:09am

Request Review

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2026

📝 Walkthrough

Walkthrough

This pull request introduces a new optional defer prop to the Tooltip component system. The change adds the defer prop across three files: it is declared in the base Tooltip component, propagated through the Tooltip App wrapper component, and utilised in the SkillsModal component. The defer prop is passed to the Teleport component to defer its rendering until after the component is mounted, rather than rendering during the initial phase.

Suggested reviewers

  • knowler
  • danielroe
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description 'fix #1483' directly references the linked issue and relates to the changeset which addresses the navigation blocking issue.
Linked Issues check ✅ Passed The changes add defer prop to tooltip components to fix the navigation issue by preventing premature tooltip initialization that was blocking page navigation [#1483].
Out of Scope Changes check ✅ Passed All changes are scoped to tooltip defer functionality across SkillsModal.vue, Tooltip/App.vue, and Tooltip/Base.vue, directly addressing the linked issue requirement.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevv ghostdevv added this pull request to the merge queue Feb 14, 2026
Merged via the queue into npmx-dev:main with commit 2744fd4 Feb 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ghostdevv ghostdevv ghostdevv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

View source for skill doesn't open the new page

2 participants

@rzzf @ghostdevv